Pull request 를 생성하실 때, pull request의 범위를 설명하는데 도움이 될 수 있는 간편한 템플릿을 준비해 뒀습니다. Pull request 에 대한 테스트를 추가해 주시는 것은 매우 중요하며 커뮤니티에게도 큰 도움이 됩니다. 각각의 pull request는 핵심 기여자(pull request의 merge권한이 있는 누군가) 가 검토하게 됩니다. Based on the type and content of the pull request, it could be:
merged immediately or
put on hold, where the reviewer requires changes (styling, tests etc.)
put on hold, if discussion is necessary (community, core team etc.)
NOTE: If your pull request is a new feature, it is best to discuss with the core team first, to ensure that it will align with the evolution of the framework.
NOTE: Please make sure that the target branch that you send your pull request is correct and that you have already rebased your code. Pull requests to the master branch are not allowed
Zephir 프로그래밍이 쉽지 않으시다면, 그밖에도 기여할 수 있는 영역은 차고 넘칩니다. 문서의 오탈자나 문맥 오류는 언제나 잡아내실 수 있구요. 각 페이지 내에서 예시를 추가해서 문서를 향상시키는 것도 가능하지요.
All you have to do is go to our docs repository, fork it, make the changes and send us a pull request.
NOTE: Note that changes to the docs repository are allowed only to the English documents (en folder).
If you wish to contribute to Phalcon by translating our documents in your native tongue, you can utilize the excellent service of our friends at Crowdin. Our project is located here. 리스트에 당신의 언어가 보이지 않는다면, 추가할 수 있도록 우리에게 메시지를 보내주세요.
NOTE: We only accept bug reports, new feature requests and pull requests in GitHub. For questions regarding the usage of the framework or support requests please visit the official forum or our Discord server.
버그 리포트 체크리스트
Make sure you are using the latest released version of Phalcon before creating an issue in GitHub.
Only bugs found in the latest released version of Phalcon will be addressed.
We have a handy template when creating an issue to help you provide as much information for the core team to reproduce and address. Being able to reproduce a bug significantly reduces the time to find the cause and fix it. Scripts of even failing tests are more than appreciated. Please check how to create the reproducible tests page for more information.
As part of your report, please include additional information such as the OS, PHP version, Phalcon version, web server, memory etc.
Pull requests to the master branch are not accepted. Please fork the repository and create your branch from the necessary “source” branch, for instance 4.0.x and if need be rebase your branch before submitting your pull request. If there are collisions, we will ask you to rebase your branch again.
Add tests to your pull request or adjust existing ones. This is very important since it helps justify your pull request. Please check our testing page for more information on how to set up a test environment and how to write tests.
Since Phalcon is written in Zephir, please do not submit commits that modify the C generated files directly
Phalcon follows a specific coding style. Please install the editorconfig plugin in your favorite IDE to take advantage of the supplied .editorconfig file that comes with this repository and not to have to worry about coding standards. All tests (PHP code), follow the PSR-12 standard
Remove any change to ext/kernel, *.zep.c and *.zep.h files before submitting the pull request
Before submitting new functionality, please open a NFR as a new issue on GitHub to discuss the impact of including the functionality or changes in the core extension. 기능이 승인되면, PR이 다음을 포함하고 있는지 다시한번 확인해 주세요:
An update to the CHANGELOG.md
Documentation or Usage Examples
If you have any questions about how to use Phalcon, please see the support page.
If you have any changes or new features in mind, please fill an NFR.